[webkit-reviews] review denied: [Bug 12878] Support for each ( var in collection ) syntax : [Attachment 13364] Adds support for for..each..in

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Feb 24 12:41:05 PST 2007

Alexey Proskuryakov <ap at webkit.org> has denied Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 12878: Support for each ( var in collection ) syntax

Attachment 13364: Adds support for for..each..in

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r- for purely stylistic issues discussed via IRC (star and comma positioning,
assert vs. ASSERT). And clearly, this cannot be landed to trunk before the
stabilization period ends.

A couple additional stylistic notes:

+	 if (varDecl)
+    s << "var " << varDecl;

  Indentation looks broken here.

+	     if ((c.complType() == Break) && ls.contains(c.target()))
+	     break;

  And here.

+    JSValue* e;
+    e = expr->evaluate(exec);

  There is no need to declare local variables at the beginning of the function
in C++. Also, this and other variables may benefit from a more descriptive

More information about the webkit-reviews mailing list