[webkit-reviews] review requested: [Bug 4045] JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 : [Attachment 13359] naive fix

[bugzilla-request-daemon at macosforge.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 4045: JavaScript call stack limit of 99 is too small for some applications;
needs to be closer to 500
http://bugs.webkit.org/show_bug.cgi?id=4045

Attachment 13359: naive fix
http://bugs.webkit.org/attachment.cgi?id=13359&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I guess this is more like a request for comments than a real proposed patch,
but this bug blocks a HitList one, so I'll shoot anyway...

The stack size was decreased to 100 in r2184:

-------------------------------------------------------------
r2184 | darin | 2002-09-27 21:27:43 +0400 (Fri, 27 Sep 2002) | 5 lines

	- fixed 3033969 -- repro crash (infinite recursion in JavaScript)
	clicking on "screens" option at fsv.sf.net

	* kjs/object.h: Change recursion limit to 100 levels rather than 1000.
-------------------------------------------------------------

I have tried clicking on "screens" option at fsv.sf.net after raising the
limit, and didn't get a crash on a PowerPC Mac. The included test doesn't crash
either, of course (I ran it under GuardMalloc).

I should also mention that the recursion counter in a static variable doesn't
look thread-safe to me.