[webkit-reviews] review granted: [Bug 12876] Gdk improvements : [Attachment 13357] Gdk improvements

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Feb 24 00:26:43 PST 2007

Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 12876: Gdk improvements

Attachment 13357: Gdk improvements

------- Additional Comments from Adam Roben <aroben at apple.com>
+		 StringImpl *txt = new StringImpl("Welcome to Gdk Web

   I know this is commented out, but you can just allocate this on the stack.

 #include "PlatformString.h"
+#include "ResourceHandleManager.h"

   No need for the newline between these two.

+    if (!str || !*str)
+	 return true;
+    return false;

   This can just be:

return !str || !*str;

     if (0 == strcmp(str1, str2))
-	 return 1;
-    return 0;
+	 return true;
+    return false;

   Similar comment here.

+    GtkWidget *topLevelWindow = gtk_window_new(GTK_WINDOW_TOPLEVEL);

   You've got a misplaced * here.

+    gFrame = new FrameGdk(page, 0, frameLoaderClient);

   This can also be on the stack.


More information about the webkit-reviews mailing list