[webkit-reviews] review requested: [Bug 12870] REGRESSION: Safari accepts and attempts to load any file dragged into it : [Attachment 13356] instamatic fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 23 17:21:11 PST 2007


Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 12870: REGRESSION: Safari accepts and attempts to load any file dragged
into it
http://bugs.webkit.org/show_bug.cgi?id=12870

Attachment 13356: instamatic fix
http://bugs.webkit.org/attachment.cgi?id=13356&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Okay, the problem is that the drag and drop code had an "improvement" that
short circuited the evaluation of _web_best_URL if the dragging  Pasteboard
contained any url.  _web_best_URL filters out insane URLs (eg. directories) so
this was bad.  This fix stops directories from being accepted.

All other files are accepted, and will bring up the finder if the dropped file
isn't viewable with webkit.



More information about the webkit-reviews mailing list