[webkit-reviews] review requested: [Bug 12866] REGRESSION: BenchJS test 6 is 12% slower in TOT than Safari 2.0.4 : [Attachment 13351] Patch to rewrite RenderView::layout()

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 23 14:35:06 PST 2007

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 12866: REGRESSION: BenchJS test 6 is 12% slower in TOT than Safari 2.0.4

Attachment 13351: Patch to rewrite RenderView::layout()

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This will need a lot of testing.  It reworks RenderView::layout as follows:

(1) Avoid always laying out the root (it only does so now if the visible view
size changes).
(2) Never setMinMaxKnown to false ever.  Let the normal mechanism for that
always be used.
(3) Stop the relayout of positioned objects.  With calcWidth() and calcHeight()
already overridden, the initial containing block size was already correct.
(4) Treat the docWidth() and docHeight() as overflow and let the normal layer
sizing mechanisms handle sizing the layer.
(5) Removed the flexible box layout hack from RenderView, since nobody is using
it any more and it was wrong anyway.

More information about the webkit-reviews mailing list