[webkit-reviews] review denied: [Bug 12609] Any SVG element will create renderers even when children of HTML elements : [Attachment 13343] First attempt

[bugzilla-request-daemon at macosforge.org]

Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 12609: Any SVG element will create renderers even when children of HTML
elements
http://bugs.webkit.org/show_bug.cgi?id=12609

Attachment 13343: First  attempt
http://bugs.webkit.org/attachment.cgi?id=13343&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
+    if (parentNode() && (parentNode()->isSVGElement() ||
+	 parentNode()->isDocumentNode() ||
+	 parentNode()->namespaceURI() != HTMLNames::xhtmlNamespaceURI))
+	 return StyledElement::rendererIsNeeded(style);
+
+    return false;

1) I don't think you should check for the HTML namespace, instead, you should
check that the parent is in the SVG namespace (or an SVG element or whatever).

2) I don't think the document node check is right - <circle> as a root of a
document should not render.

3) This should specifically allow the <svg:svg> element to render inside a
parent of any namespace.