[webkit-reviews] review requested: [Bug 12854] Allow FrameLoaderClient to override navigator.appVersion : [Attachment 13338] Updated patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Feb 22 21:04:01 PST 2007

Oscar Cwajbaum <public at oscarc.net> has asked  for review:
Bug 12854: Allow FrameLoaderClient to override navigator.appVersion

Attachment 13338: Updated patch

------- Additional Comments from Oscar Cwajbaum <public at oscarc.net>
I removed 'const' as suggested.

Please reconsider this patch for the reasons I stated earlier. In summary,
client code can already affect appVersion, and therefore introduce
compatibility differences. Why restrict the appVersion to a substring of the
UA, especially when there are cases that this is not desirable?

More information about the webkit-reviews mailing list