[webkit-reviews] review requested: [Bug 12399] REGRESSION: Unable to prevent default context menu from appearing. : [Attachment 13329] Clear the controller's context menu before sending the event through the DOM

[bugzilla-request-daemon at macosforge.org]

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 12399: REGRESSION: Unable to prevent default context menu from appearing.
http://bugs.webkit.org/show_bug.cgi?id=12399

Attachment 13329: Clear the controller's context menu before sending the event
through the DOM
http://bugs.webkit.org/attachment.cgi?id=13329&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
This problem appeared because of two facets of the current context menu design.
First, all context menu events are now considered to be "swallowed" since we
take care of building up the regular context menu through the
defaultEventHandler(). Second, the context menu controller holds onto it's
context menu until a new one is created. There would be logistical problems
changing this since AppKit relies on the menu being around for as long as it is
visible on the screen and we don't get any notification once the menu is
popped-down. 

There are a few different ways to fix this problem, but I think this is
simplest. This solution does not change either of the two thing described
above. It just clears out the controller's context menu before a new event is
propagated through the DOM.