[webkit-reviews] review requested: [Bug 12327] Windows build
bustage + vcproj/sln craziness : [Attachment 13316] Split
patch for r19793, part 1: .vcproj cleanup
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Thu Feb 22 10:36:06 PST 2007
Don Gibson <dgibson77 at gmail.com> has asked for review:
Bug 12327: Windows build bustage + vcproj/sln craziness
http://bugs.webkit.org/show_bug.cgi?id=12327
Attachment 13316: Split patch for r19793, part 1: .vcproj cleanup
http://bugs.webkit.org/attachment.cgi?id=13316&action=edit
------- Additional Comments from Don Gibson <dgibson77 at gmail.com>
OK, I'm trying to manually split the latest patch as requested, in hopes of
easier review. This is part 1 of 3, which does a lot of .vcproj cleanup (and
some small script changes too).
I would not advise landing these split patches in isolation; if at all possible
you should land a monolithic patch, since I haven't tested the various
combinations of the patches, and since parts 2 and 3 are definitely necessary
to fix the build, and part 1 should land now (while the build is busted) rather
than later anyway.
More information about the webkit-reviews
mailing list