[webkit-reviews] review denied: [Bug 11447] REGRESSION(NativeListBox): List not scrolled to preselected option : [Attachment 13314] initiate scroll from insertedIntoDocument to cover dynamic cases too

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 11447: REGRESSION(NativeListBox): List not scrolled to preselected option
http://bugs.webkit.org/show_bug.cgi?id=11447

Attachment 13314: initiate scroll from insertedIntoDocument to cover dynamic
cases too
http://bugs.webkit.org/attachment.cgi?id=13314&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'd like to see the test case cover all three of the code paths.

The ChangeLog doesn't mention the new HTMLOptionElement files in this patch.

+    HTMLSelectElement* select = 0;

No reason to initialize this to 0.

+//sel.setAttribute('selected','selected');

Is this commented out intentionally?

This is pretty good, but I'm going to review- it since the ChangeLog and test
case don't match the code.