[webkit-reviews] review denied: [Bug 12850] Leaks >10k objects : [Attachment 13311] fix RemoveEventListener

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Feb 22 01:04:26 PST 2007


Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 12850: Leaks >10k objects
http://bugs.webkit.org/show_bug.cgi?id=12850

Attachment 13311: fix RemoveEventListener
http://bugs.webkit.org/attachment.cgi?id=13311&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
The change itself looks good. Thanks, this will is a really valuable fix!
Technicalities:

- Needs a ChangeLog entry
- Needs a test case
- Per the coding style guidelines, the * should go next to the type name,
although it is hard to tell from the current surrounding code.

r- for now for the technicalities.



More information about the webkit-reviews mailing list