[webkit-reviews] review denied: [Bug 12515] Plug-ins that draw through the Quickdraw interface fail in a CGBitmapContex. : [Attachment 13265] Allows QD based plugins to draw into offscreen bitmap contexts. (V3)

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Tue Feb 20 11:40:30 PST 2007


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 12515: Plug-ins that draw through the Quickdraw interface fail in a
CGBitmapContex.
http://bugs.webkit.org/show_bug.cgi?id=12515

Attachment 13265: Allows QD based plugins to draw into offscreen bitmap
contexts. (V3)
http://bugs.webkit.org/attachment.cgi?id=13265&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Needs a ChangeLog entry.

This identifier is missing a "t": WKCGContextIsBitmapContex

Adding things to WebKitSystemInterface is something that needs to be handled
internally at Apple, so I don't think it's appropriate to have it here in an
open source patch! You need to work with someone on my team -- please contact
Oliver Hunt.

Are you sure we don't want the "forUpdate" logic when the target is a
CGBitmapContext? I'm concerned that we'll end up drawing outside the damaged
area in that case -- I think the logic applies equally well to the
CGBitmapContext case, but there may be something I'm missing.

+	     SetGWorld(qdPortState->oldPort, NULL);
	     SetPort(qdPortState->oldPort);

Do we really need both the SetGWorld call and the SetPort call? My QuickDraw is
a little rusty, but I don't think that's right. I seem to recall that in the
old days you had to separately save and restore the port and the gdevice, and
SetGWorld would set both.

How is the TSMEventHandler change related to this bug? It doesn't seem to have
anything to do with CGBitmapContext.



More information about the webkit-reviews mailing list