[webkit-reviews] review denied: [Bug 12821] Number.toExponential doesn't work for negative numbers : [Attachment 13261] Inverts negative numbers so that they pass

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Feb 19 19:39:05 PST 2007


Mark Rowe (bdash) <bdash at webkit.org> has denied Mark Rowe (bdash)
<bdash at webkit.org>'s request for review:
Bug 12821: Number.toExponential doesn't work for negative numbers
http://bugs.webkit.org/show_bug.cgi?id=12821

Attachment 13261: Inverts negative numbers so that they pass
http://bugs.webkit.org/attachment.cgi?id=13261&action=edit

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
r- for style issues.  As mentioned on IRC I'm not sure that this is the best
solution to the problem.  The if (!fractionDigits->isUndefined()) { ... } block
is resulting in a negative x value becoming NaN.  If you can work out why that
happens a cleaner fix may present itself.



More information about the webkit-reviews mailing list