[webkit-reviews] review requested: [Bug 10735] Clicking in SVG
results causes WebKit to consume 100% CPU for several minutes
: [Attachment 13243] Use an iterator that doesn't maintain
child indices
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Mon Feb 19 11:56:24 PST 2007
mitz at webkit.org has asked for review:
Bug 10735: Clicking in SVG results causes WebKit to consume 100% CPU for
several minutes
http://bugs.webkit.org/show_bug.cgi?id=10735
Attachment 13243: Use an iterator that doesn't maintain child indices
http://bugs.webkit.org/attachment.cgi?id=13243&action=edit
------- Additional Comments from mitz at webkit.org
(In reply to comment #10)
> Could we make the helper functions public instead of private? Then
> PositionIterator would not need to be a friend.
Done.
> Why does Position need to be a friend of PositionIterator?
The Position(const PositionIterator&) constructor accesses private members. I
left it this way in this patch because it's the lesser evil of the alternatives
I could think of.
Also fixed the indentation of the friend declaration and moved another star.
More information about the webkit-reviews
mailing list