[webkit-reviews] review denied: [Bug 12802] WebKit.framework is built with SVG_SUPPORT for No-SVG build : [Attachment 13221] patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Feb 19 08:30:19 PST 2007


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 12802: WebKit.framework is built with SVG_SUPPORT for No-SVG build
http://bugs.webkit.org/show_bug.cgi?id=12802

Attachment 13221: patch
http://bugs.webkit.org/attachment.cgi?id=13221&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This looks slightly sloppy to me. I'm not sure why JavaScriptCore should not
have FEATURE_DEFINES, yet JavaScriptGlue should have it. And why have a
separate elsif for WebCore if it's the same as the else case?

Would you be willing to try again? I think passing FEATURE_DEFINES to all the
projects is fine, so the entire if/elsif/else can go.



More information about the webkit-reviews mailing list