[webkit-reviews] review granted: [Bug 10735] Clicking in SVG results causes WebKit to consume 100% CPU for several minutes : [Attachment 13237] Use an iterator that doesn't maintain child indices

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Feb 19 08:27:39 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 10735: Clicking in SVG results causes WebKit to consume 100% CPU for
several minutes
http://bugs.webkit.org/show_bug.cgi?id=10735

Attachment 13237: Use an iterator that doesn't maintain child indices
http://bugs.webkit.org/attachment.cgi?id=13237&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+friend class PositionIterator;

Normaly we'd indent this kind of friend declaration.

Could we make the helper functions public instead of private? Then
PositionIterator would not need to be a friend.

Why does Position need to be a friend of PositionIterator?

r=me, anyway



More information about the webkit-reviews mailing list