[webkit-reviews] review denied: [Bug 12801] Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document : [Attachment 13225] Look for <body> (and assert if not found) only in HTML documents

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Feb 18 09:53:31 PST 2007


Alexey Proskuryakov <ap at webkit.org> has denied Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 12801: Assertion failure in createMarkup() (root) when doing Select All,
Copy in an SVG document
http://bugs.webkit.org/show_bug.cgi?id=12801

Attachment 13225: Look for <body> (and assert if not found) only in HTML
documents
http://bugs.webkit.org/attachment.cgi?id=13225&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I think it is wrong to introduce different behavior for HTML and XHTML here
(since isHTMLDocument() returns false for XHML).

I am not quite sure about the correct solution, but maybe one can just traverse
up the hierarchy until seeing either a node that's not an HTML element, or a
body.



More information about the webkit-reviews mailing list