[webkit-reviews] review denied: [Bug 12783] curl networking improvements for gdk build : [Attachment 13195] curl networking improvements

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 16 23:06:56 PST 2007

Oliver Hunt <oliver at apple.com> has denied Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 12783: curl networking improvements for gdk build

Attachment 13195: curl networking improvements

------- Additional Comments from Oliver Hunt <oliver at apple.com>

+	 struct curl_slist *m_customHeaders;   
WebKit style guide is Type* ident
so "struct curl_slist* m_customHeaders"

*  in the wrong place again:
+	 ResourceHandle *job;
+	 ResourceHandleInternal *d = job->getInternal();
+	     char *url = 0;
+	 struct curl_slist *headers = 0;
+	     const char *header = headerString.latin1().data();
+    char * m_cookieJarFileName; // FIXME: never freed

Otherwise looks reasonable -- but i cannot vouch for correctness, i don't know
gdk at all.

More information about the webkit-reviews mailing list