[webkit-reviews] review granted: [Bug 12783] curl networking
improvements for gdk build : [Attachment 13195] curl
networking improvements
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Fri Feb 16 23:01:22 PST 2007
Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 12783: curl networking improvements for gdk build
http://bugs.webkit.org/show_bug.cgi?id=12783
Attachment 13195: curl networking improvements
http://bugs.webkit.org/attachment.cgi?id=13195&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
+ free((void*)m_url);
Is this cast to void* really necessary?
+ for (;;) {
I believe while (true) is a bit more inline with our coding style.
+ void setupPOST(ResourceHandle* job);
+ void setupPUT(ResourceHandle* job);
You should remove the parameter names here.
I don't know much about curl, but this code looks sane. r=me.
More information about the webkit-reviews
mailing list