[webkit-reviews] review denied: [Bug 12786] Crashes on arm due to different struct packing : [Attachment 13198] fix arm crashes due to different struct packing

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 16 22:48:25 PST 2007


Oliver Hunt <oliver at apple.com> has denied Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 12786: Crashes on arm due to different struct packing
http://bugs.webkit.org/show_bug.cgi?id=12786

Attachment 13198: fix arm crashes due to different struct packing
http://bugs.webkit.org/attachment.cgi?id=13198&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I'd be tempted to make it #if PLATFORM(ARM) (do we have that?) and if all
possible move the compileassertion (and the Assertion.h include into a C file
(we're already taking a long time to copile, aroben has been attempting to
reduce the number of includes in headers)

Also, it might be worth putting the 
+#if COMPILER(GCC)
+#define PACK_STRUCT __attribute__((packed))
+#else
+#define PACK_STRUCT
+#endif
 into config.h



More information about the webkit-reviews mailing list