[webkit-reviews] review granted: [Bug 12785] Linux/gdk improvements : [Attachment 13197] move Path to its own file, GraphicsContext cairo additions

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 16 21:38:21 PST 2007


Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 12785: Linux/gdk improvements
http://bugs.webkit.org/show_bug.cgi?id=12785

Attachment 13197: move Path to its own file, GraphicsContext cairo additions
http://bugs.webkit.org/attachment.cgi?id=13197&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
-    notImplemented();
+    // notImplemented(); // commented-out because it's chatty and clutters
output

   A better fix might be to make notImplemented() only print once per function,
as opposed to once per call.

   You should also set svn:eol-style native on all new files.

   r=me



More information about the webkit-reviews mailing list