[webkit-reviews] review denied: [Bug 12327] Windows build bustage + vcproj/sln craziness : [Attachment 13202] patch for r19659

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 16 21:35:46 PST 2007

Adam Roben <aroben at apple.com> has denied Adam Roben <aroben at apple.com>'s
request for review:
Bug 12327: Windows build bustage + vcproj/sln craziness

Attachment 13202: patch for r19659

------- Additional Comments from Adam Roben <aroben at apple.com>
This is certainly an improvement, but we shouldn't be overhauling the build
system so thoroughly while also trying to just get things building again.
Changing the build system like this will break existing contributors'
configurations. Again, it's very hard to review a patch of this size at all,
and especially hard without a detailed ChangeLog. I'd really like to see this
patch split up into smaller chunks that can be reviewed and discussed

More information about the webkit-reviews mailing list