[webkit-reviews] review granted: [Bug 12214] REGRESSION: css image with relative path is not loaded, when both base element and dir attribute in the html tag are present : [Attachment 13156] baseURL fix and testcase added

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Feb 14 09:00:00 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12214: REGRESSION: css image with relative path is not loaded, when both
base element and dir attribute in the html tag are present
http://bugs.webkit.org/show_bug.cgi?id=12214

Attachment 13156: baseURL fix and testcase added
http://bugs.webkit.org/attachment.cgi?id=13156&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Given our discussion of @import, I'm surprised you didn't also add @import
tests.

+	 m_elemSheet.get()->setHref(m_baseURL);

I mentioned in the last review that you didn't need a get() here. Was there a
reason you didn't remove it?

Change looks fine, r=me, but I get a strange sense that you didn't pay
attention to my comments last time!



More information about the webkit-reviews mailing list