[webkit-reviews] review requested: [Bug 12750] Vector compare
operator is broken : [Attachment 13144] patch for Vector
comparison operators
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Mon Feb 12 18:12:32 PST 2007
Dex Deacon <occupant4 at gmail.com> has asked for review:
Bug 12750: Vector compare operator is broken
http://bugs.webkit.org/show_bug.cgi?id=12750
Attachment 13144: patch for Vector comparison operators
http://bugs.webkit.org/attachment.cgi?id=13144&action=edit
------- Additional Comments from Dex Deacon <occupant4 at gmail.com>
Actually, it turns out that after fixing #1, the implicit cast was being used
only because the operator== was still broken in other ways. Specifically, it
didn't accept const Vectors, so it wouldn't be used for all callers.
After fixing Vector's operator==, I had to also add an operator!= for a class
that previously wasn't being compared at all in RenderStyle.h.
More information about the webkit-reviews
mailing list