[webkit-reviews] review granted: [Bug 10144] REGRESSION: Reproducible assertion failure in DeleteSelectionCommand::fixupWhitespace() : [Attachment 13119] Patch, including change log and test

[bugzilla-request-daemon at macosforge.org]

Maciej Stachowiak <mjs at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 10144: REGRESSION: Reproducible assertion failure in
DeleteSelectionCommand::fixupWhitespace()
http://bugs.webkit.org/show_bug.cgi?id=10144

Attachment 13119: Patch, including change log and test
http://bugs.webkit.org/attachment.cgi?id=13119&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

This seems like a pretty non-obvious way to say "broke at a newline that has
been deleted":

prevRootBox->lineBreakObj()->isText() && prevRootBox->lineBreakPos() >=
static_cast<RenderText*>(prevRootBox->lineBreakObj())->textLength()

May I suggest making an inline function for this condition, something like
"brokeAtDeletedNewline()"? This might make the comment less necessary (although
it's still not obvious that "curr = prevRootBox" means "treat previous line as
dirty".