[webkit-reviews] review requested: [Bug 12733] XPath namespace is attached to a wrong step : [Attachment 13116] proposed fix

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Feb 11 03:06:11 PST 2007


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 12733: XPath namespace is attached to a wrong step
http://bugs.webkit.org/show_bug.cgi?id=12733

Attachment 13116: proposed fix
http://bugs.webkit.org/attachment.cgi?id=13116&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Suggestions are welcome on how to reduce code duplication in XPathGrammar.y. I
thought about changing the type of NodeTest to a (string, namespace) pair, but
this seemed unfair to other tests that do not use a namespace.



More information about the webkit-reviews mailing list