[webkit-reviews] review requested: [Bug 12687] REGRESSION: Google Calendar cell highlight misplaced : [Attachment 13091] proposed patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Feb 9 13:26:38 PST 2007

Antti Koivisto <koivisto at iki.fi> has asked  for review:
Bug 12687: REGRESSION: Google Calendar cell highlight misplaced

Attachment 13091: proposed patch

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Ok, so here is proposed patch. It does three things
1) calculate offsets from padding edge (inner edge of border), not from border
2) revert this 

!(!style()->htmlHacks() && skipTables ? curr->isRoot() : curr->isBody())

in http://trac.webkit.org/projects/webkit/changeset/11484 back to this


which seems to match FF behavior in both strict and compat modes. Why was this
change done? Hard to say since there was no test case nor explanation.

3) Check for tableness from dom tree instead of rendering tree. That's just
what other browser seem to do based on Anne's tests.

These changes make all Anne's tests pass except for 3,8,12,29,43,45,49,50. In
all those cases we match FF behavior (except 12, where we fail a bit less).
Failures are of course all debatable since there is no authorative spec about
offset behaviors. No layout test failures either.

(some of Anne's test cases may randomly produce wrong offsetTop results when
reloaded. that is some layout timing problem not directly related to offset

None of this actually fixes Google Calendar, it needs ToT fixes in the other
end. Best we can do is to make this stuff consistent.

More information about the webkit-reviews mailing list