[webkit-reviews] review denied: [Bug 5468] CSS3: last-child, last-of-type, only-child and only-of-type pseudo-selectors : [Attachment 13032] lets see if dave likes this one any better

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Feb 8 21:15:10 PST 2007


Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 5468: CSS3: last-child, last-of-type, only-child and only-of-type
pseudo-selectors
http://bugs.webkit.org/show_bug.cgi?id=5468

Attachment 13032: lets see if dave likes this one any better
http://bugs.webkit.org/attachment.cgi?id=13032&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Patch looks good.  Since the tests that are being landed are expected failures,
I'd prefer they go under css3/expected_failures/ (as we did with table tests
that have failing results), so that there's no confusion about the fact that
we're deliberately checking in failing test cases.

I'll r+ once the tests are moved.



More information about the webkit-reviews mailing list