[webkit-reviews] review granted: [Bug 12160] Linux/Gdk build fixes : [Attachment 13022] Linux\gdk build fixes - el patch numero huit

[bugzilla-request-daemon at macosforge.org]

Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 12160: Linux/Gdk build fixes
http://bugs.webkit.org/show_bug.cgi?id=12160

Attachment 13022: Linux\gdk build fixes - el patch numero huit
http://bugs.webkit.org/attachment.cgi?id=13022&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
 #include "ChromeClient.h"
+#include "Shared.h"

   Shared.h shouldn't be necessary anymore.

+    // FIXME: optimize the way CursorQt is optmized: only one copy of a given
+    // cursor type
+    static Cursor c = gdk_cursor_new(GDK_LEFT_PTR);

   I think you've already implemented this FIXME. Since c is static
gdk_cursor_new will only be called once.

 #include <assert.h>
 #include <gdk/gdk.h>
+#include "SystemTime.h"

   SystemTime.h should go above <assert.h>

+    m_shiftKey = event->button.state & GDK_SHIFT_MASK != 0;
+    m_ctrlKey = event->button.state & GDK_CONTROL_MASK != 0;
+    m_altKey = event->button.state & GDK_MOD1_MASK != 0;
+    m_metaKey = event->button.state & GDK_MOD2_MASK != 0;

   The '!= 0' is redundant in each of these cases.

   r=me.