[webkit-reviews] review denied: [Bug 6286] Very large (~500MB) images cause reproducible Safari crash : [Attachment 13030] Proposed fix.

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Feb 7 18:15:48 PST 2007

Sam Weinig <sam at webkit.org> has denied Sam Weinig <sam at webkit.org>'s request
for review:
Bug 6286: Very large (~500MB) images cause reproducible Safari crash

Attachment 13030: Proposed fix.

------- Additional Comments from Sam Weinig <sam at webkit.org>
Hi, still a bunch of style issues.

First, we do not use tabs at all, so please remove all the tabs you added to
both the Changelog and CachedImage.cpp

Please add your email address to the Changelog
+2007-02-07  Christopher Brichford  <set EMAIL_ADDRESS environment variable>

We don't put spaces inside the parenthesis and we put the brace on the same
line, so
+ if ( addedSize > 0 )
+ {

should be 
+ if (addedSize > 0) {

same here
+  if ( newSize > oldSize )
+  {

and here
+   if ( tempBufferBytes )
+   {

Please put a space before the comment.
+ //Check for overflow

More information about the webkit-reviews mailing list