[webkit-reviews] review denied: [Bug 6286] Very large (~500MB) images cause reproducible Safari crash : [Attachment 13019] Proposed fix.

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Feb 7 17:25:05 PST 2007

Maciej Stachowiak <mjs at apple.com> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 6286: Very large (~500MB) images cause reproducible Safari crash

Attachment 13019: Proposed fix.

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
The basic code change looks great! However, I suggest fixing the following

1) This needs a ChangeLog entry
2) There are some misplaced spaces, per our coding style, we don't use spaces
inside the parens for if statements and function calls.

3) The comment seem longer than necessary, we usually just stick to brief
comments explaining why something possibly mysterious is being done, rather
than focusing on what the code is doing. Ideally the "what" part should be

4) Single-line if conditions don't take braces, so for instance this:

+		if ( ! success )
+		{
+			error();
+		}

Should just be:

if (!success)

More information about the webkit-reviews mailing list