[webkit-reviews] review denied: [Bug 12123] REGRESSION: Incomplete repaint of floats' overflows : [Attachment 12907] Assign painting of overflowing floats to the parent

[bugzilla-request-daemon at macosforge.org]

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 12123: REGRESSION: Incomplete repaint of floats' overflows
http://bugs.webkit.org/show_bug.cgi?id=12123

Attachment 12907: Assign painting of overflowing floats to the parent
http://bugs.webkit.org/attachment.cgi?id=12907&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Ok, I think conceptually this is good.	I have a slight concern about
performance in that you removed some hasOverhangingFloats() checks in favor of
simply always walking the floating objects list.  This means all the floats
that don't overhang or overflow are being examined all the time now.

Seems like you should rename  repaintOverhangingFloats to
repaintOverflowingFloats, since it now repaints both potentially.

Please add flexible box tests for both the horizontal and vertical directions.

Please add tests for inline blocks and inline tables.