[webkit-reviews] review denied: [Bug 5468] CSS3: last-child, last-of-type, only-child and only-of-type pseudo-selectors : [Attachment 12999] patch to *remove* support for these properties

[bugzilla-request-daemon at macosforge.org]

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 5468: CSS3: last-child, last-of-type, only-child and only-of-type
pseudo-selectors
http://bugs.webkit.org/show_bug.cgi?id=5468

Attachment 12999: patch to *remove* support for these properties
http://bugs.webkit.org/attachment.cgi?id=12999&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Yeah, I agree with removing support for these.

You haven't adequately removed them unless the rules are rejected.  You need to
go further and actually yank the names from the list of pseudo types
completely.

For  example:

:last-child, div { color: red }

should be rejected since last-child is unrecognized.

Also,

:not(:last-child)

needs to also be rejected.  With your patch :last-child just always returns a
failed match, which will cause :not(:last-child) to always match.