[webkit-reviews] review granted: [Bug 12582] REGRESSION: Unclosed
<title> makes the window display garbage or empty title :
[Attachment 13012] proposed fix
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Wed Feb 7 12:19:10 PST 2007
Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12582: REGRESSION: Unclosed <title> makes the window display garbage or
empty title
http://bugs.webkit.org/show_bug.cgi?id=12582
Attachment 13012: proposed fix
http://bugs.webkit.org/attachment.cgi?id=13012&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
OK.
I'm convinced this is correct. Let me note in passing that I'm unhappy with the
structure and readability of the function.
It took me a really long time studying the code to understand why it's OK to
look at stringBuilder[builderIndex] when builderIndex is 0, even though that's
"off the end of the array".
More information about the webkit-reviews
mailing list