[webkit-reviews] review granted: [Bug 12160] Linux/Gdk build fixes
: [Attachment 12991] Linux\gdk build fixes - el patch numero treis
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Wed Feb 7 10:09:25 PST 2007
Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 12160: Linux/Gdk build fixes
http://bugs.webkit.org/show_bug.cgi?id=12160
Attachment 12991: Linux\gdk build fixes - el patch numero treis
http://bugs.webkit.org/attachment.cgi?id=12991&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
+#include <cairo.h>
#include "FloatRect.h"
#include "Font.h"
+#include "FontData.h"
#include "IntRect.h"
-#include <cairo.h>
#include <math.h>
+#include <stdio.h>
cairo.h should stay where it was, above math.h.
-void GraphicsContext::setFocusRingClip(const IntRect&)
+void GraphicsContext::setFocusRingClip(const IntRect& rect)
This change is unnecessary.
+void GraphicsContext::setPlatformFillColor(const Color& col)
+{
+ setColor(m_data->context, col);
+ cairo_fill(m_data->context);
Does cairo_fill actually do a fill? That's not what we want here, we just
want to set a color for when a fill does happen later. Ditto for stroke.
+ if (m_decoder) {
+ delete m_decoder;
+ m_decoder = 0;
Null check is unnecessary. There's an extra space after 'delete'.
+ BitmapImage* img = new BitmapImage();
Parentheses are unnecessary here.
If cairo_stroke and cairo_fill don't actually do a stroke/fill, r=me.
More information about the webkit-reviews
mailing list