[webkit-reviews] review denied: [Bug 12635] [S60] SW-V: Browser: Bookmarks with an URL containing spaces do not work : [Attachment 13001] 3.1 patch - escape Url

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Feb 7 07:34:47 PST 2007


Zalan Bujtas <zbujtas at gmail.com> has denied Zalan Bujtas <zbujtas at gmail.com>'s
request for review:
Bug 12635: [S60] SW-V: Browser: Bookmarks with an URL containing spaces do not
work
http://bugs.webkit.org/show_bug.cgi?id=12635

Attachment 13001: 3.1 patch - escape Url
http://bugs.webkit.org/attachment.cgi?id=13001&action=edit

------- Additional Comments from Zalan Bujtas <zbujtas at gmail.com>
iUrl needs to be set to NULL before the allocation beacuse EscapeEncodeL could
leave and then the CUrlRequestInfo::~CUrlRequestInfo would delete iUrl twice.

delete iUrl;
iUrl = NULL;
iUrl = EscapeUtils::EscapeEncodeL( aUrl, EscapeUtils::EEscapeNormal );

and please do not change the coding style
+void CUrlRequestInfo::SetUrlL( const TDesC& aUrl )



More information about the webkit-reviews mailing list