[webkit-reviews] review granted: [Bug 12160] Linux/Gdk build fixes : [Attachment 12995] Linux\gdk build fixes - el patch numero siete

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Feb 7 02:03:39 PST 2007

Maciej Stachowiak <mjs at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 12160: Linux/Gdk build fixes

Attachment 12995: Linux\gdk build fixes - el patch numero siete

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I'm not sure ResourceHandleManager::self() is a good name. get() was kind of
vague, but a more typical name for a static method when applying the singleton
pattern like this would be sharedInstance() or just shared(). Otherwise these
changes look fine. r=me and feel free to adjust name when landing if you want.

More information about the webkit-reviews mailing list