[webkit-reviews] review granted: [Bug 12160] Linux/Gdk build fixes : [Attachment 12990] Linux\gdk build fixes - el patch numero dos

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Wed Feb 7 01:45:22 PST 2007

Adam Roben <aroben at apple.com> has granted Adam Roben <aroben at apple.com>'s
request for review:
Bug 12160: Linux/Gdk build fixes

Attachment 12990: Linux\gdk build fixes - el patch numero dos

------- Additional Comments from Adam Roben <aroben at apple.com>
+namespace WebCore

   The opening brace should be on the same line as namespace WebCore.

+    // FIXME: this method always returns true
+    notImplemented();
+    return false;

   The comment here seems completely incorrect.

+bool EventHandler::handleDrag(const MouseEventWithHitTestResults& event)
+    //notImplemented();
+    return false;

   Why is notImplented() commented out?

   Again, svn cp would be better.


More information about the webkit-reviews mailing list