[webkit-reviews] review denied: [Bug 12530] [CSS2] Support the font-stretch property : [Attachment 12867] patch v 1.2

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Mon Feb 5 17:28:28 PST 2007


Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 12530: [CSS2] Support the font-stretch property
http://bugs.webkit.org/show_bug.cgi?id=12530

Attachment 12867: patch v 1.2
http://bugs.webkit.org/attachment.cgi?id=12867&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I am actually minusing this review for a number of reasons (and this patch is
being rolled out of the tree).

font-stretch was  actually dropped from CSS2.1, and so it exists now only in a
CSS3 draft.  This property should be prefaced with the -webkit- prefix, since
it is really CSS3 now and not CSS2.1.

font-stretch needs to work all the time, just as bold/italic do.  That means it
isn't enough just to support different font variants when they do exist.  You
also need to support font synthesis.

Normally I would have left this patch in and just filed bugs suggesting that
this work be iterated on, but given that we've locked down for stabilization, I
don't want to ship a half-implemented version of this property.



More information about the webkit-reviews mailing list