[webkit-reviews] review granted: [Bug 12575] SVG Links do not show status text on hover : [Attachment 12915] even cleaner patch (and test case)

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Feb 4 18:53:05 PST 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12575: SVG Links do not show status text on hover
http://bugs.webkit.org/show_bug.cgi?id=12575

Attachment 12915: even cleaner patch (and test case)
http://bugs.webkit.org/attachment.cgi?id=12915&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+#ifdef SVG_SUPPORT
+    else if (m_innerURLElement->hasTagName(SVGNames::aTag))
+	 return m_innerURLElement->isLink();
+#endif

No need for else here. The if before ends in a return.

Would be nice if this had a layout test. We could easily add logging of the
delegate methods used for status text.

r=me



More information about the webkit-reviews mailing list