[webkit-reviews] review requested: [Bug 11839] Webarchive fails to save CSS files in @import statements : [Attachment 12925] Patch v3

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sun Feb 4 18:11:40 PST 2007

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 11839: Webarchive fails to save CSS files in @import statements

Attachment 12925: Patch v3

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
(In reply to comment #13)
> Clearing review flag.  I want to fix some of the issues raised in Comment
> specifically item #2 (recursion vs. iteration), item #3 (containsObject: on
> NSArray) and the Internal vs. Private issue.

Changes since Patch v2:

- Added layout test thanks to Bug 11882.
- Switched algorithm from recursion to iteration.
- Changed to call containsObject: on an NSMutableSet instead of an
NSMutableArray (at the cost of allocating another data structure).
- No longer modify the DOMNode _URLsFromSelectors: SPI.
- Switched Private API added (DOMCSSStyleSheet
_recursivelyAddSubresourceURLsToArray:withDOMDocument:) to Internal API
(DOMCSSStyleSheet _addSubresourceURLsToArray:withBaseURL:).
- Fixed bug when referencing CSS stylesheets outside the current URL
"directory" of the page that was being archived.

More information about the webkit-reviews mailing list