[webkit-reviews] review denied: [Bug 12562] Fix test cases that are now spewing console errors that they are not testing for : [Attachment 12903] patch

[bugzilla-request-daemon at macosforge.org]

Adam Roben <aroben at apple.com> has denied Adam Roben <aroben at apple.com>'s
request for review:
Bug 12562: Fix test cases that are now spewing console errors that they are not
testing for
http://bugs.webkit.org/show_bug.cgi?id=12562

Attachment 12903: patch
http://bugs.webkit.org/attachment.cgi?id=12903&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
   This is an awesome patch. Some of the expected results seem a bit
questionable, though.

-SUCCESS - Didn't crash
+SUCCESS

-    <div>SUCCESS - Didn't crash</div>
+    <div id="result">SUCCESS - Didn't crash</div>

   The two above changes don't seem to match up. Why is " - Didn't crash" not
appearing in the expected results?

+caret: position 1 of child 0 {INPUT} of child 0 {DIV} of child 0 {BODY} of
child 0 {HTML} of document

   If the caret is inside the <input>, won't it have a focus ring (which is
what this test says shouldn't happen)?

+try { [2, 5, 9].forEach(printEltAndException); }
+catch (e) { print(e); }

   Can you add newlines here as if it were an if-else block?

+try { [2, 5, 8, 1, 4].some(isBigEnoughAndException); }
+catch (e) { print(e); }
+
+try { [12, 5, 8, 1, 44].some(isBigEnoughAndException); }
+catch (e) { print(e); }

   Ditto.

-caret: position 9 of child 0 {#text} of child 7 {DIV} of child 7 {DIV} of
child 1 {BODY} of child 0 {HTML} of document
+selection start: position 9 of child 0 {#text} of child 3 {DIV} of child 7
{DIV} of child 1 {BODY} of child 0 {HTML} of document
+selection end:   position 0 of child 5 {DIV} of child 7 {DIV} of child 1
{BODY} of child 0 {HTML} of document

   Why are we ending up with a selection now?