[webkit-reviews] review denied: [Bug 12556] SVG text ignores
xml:space attribute : [Attachment 12896] Initial patch
bugzilla-request-daemon at macosforge.org
bugzilla-request-daemon at macosforge.org
Sat Feb 3 12:13:31 PST 2007
Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 12556: SVG text ignores xml:space attribute
http://bugs.webkit.org/show_bug.cgi?id=12556
Attachment 12896: Initial patch
http://bugs.webkit.org/attachment.cgi?id=12896&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
This new SVG_PRE value should not be in the SVG-specific files nor should it be
ifdef'd.
How exactly is SVG_PRE different from PRE_WRAP?
+ // SVG text never contains tabs!
Are you sure this is the best way to do this? We specifically don't do this to
change '\n' characters into ' ' characters.
Definitely should discuss these changes with Hyatt.
Given the number of different places changed, I want to see a separate test for
each one. Basically if I take out any one of the SVG_PRE checks, a test should
fail. We need to construct those tests.
More information about the webkit-reviews
mailing list