[webkit-reviews] review granted: [Bug 12560] W3C XPath test Text_Nodes.svg fails : [Attachment 12901] proposed fix

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 12560: W3C XPath test Text_Nodes.svg fails
http://bugs.webkit.org/show_bug.cgi?id=12560

Attachment 12901: proposed fix
http://bugs.webkit.org/attachment.cgi?id=12901&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	     if ((node->nodeType() == Node::TEXT_NODE || node->nodeType() ==
Node::CDATA_SECTION_NODE)) {

isCharacterDataNode() is another way to do the same check -- maybe we should
use that.

+	 * dom/svg/level3/xpath/Text_Nodes.js: Invert the success condition, as
the test appears incorrect.

Should we report this to the W3C?

Please add comments to the test to indicate that we've made local
modifications.

r=me