[webkit-reviews] review denied: [Bug 11811] REGRESSION (r11783): Hebrew text in list boxes is reversed : [Attachment 12891] patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Sat Feb 3 00:34:52 PST 2007

Adele Peterson <adele at apple.com> has denied Adele Peterson <adele at apple.com>'s
request for review:
Bug 11811: REGRESSION (r11783): Hebrew text in list boxes is reversed

Attachment 12891: patch

------- Additional Comments from Adele Peterson <adele at apple.com>
I'm going to rework this and post a new patch.

Things to address:

-malloc less by using a Vector<UChar>
- don't call bidi algorithm in the directional override case
- If there's one run, and its not reversed, return early

More information about the webkit-reviews mailing list