[webkit-reviews] review denied: [Bug 12530] [CSS2] Support the font-stretch property : [Attachment 12865] patch v 1.0

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Feb 1 19:56:19 PST 2007

Mark Rowe (bdash) <bdash at webkit.org> has denied Mark Rowe (bdash)
<bdash at webkit.org>'s request for review:
Bug 12530: [CSS2] Support the font-stretch property

Attachment 12865: patch v 1.0

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
I'm going to r- this for a few reasons, most of which I've mentioned on IRC:
* We can't land a failing layout test.
* Your patch has a few coding style issues (tabs in a few lines, and two
one-line-ifs which should probably be merged and indented on to two lines)
* It'd be good if you could address the "Web Inspector" issue you mention when
this is landed so that it doesn't get overlooked.

I'm far from being an expert on our CSS code, but the rest of the change looks
reasonable to me.

More information about the webkit-reviews mailing list