[webkit-reviews] review denied: [Bug 12521] Add support for CSS3 values 'start' and 'end' to text-align property : [Attachment 12855] removed BOM and tabs from test case

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Feb 1 07:42:22 PST 2007


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 12521: Add support for CSS3 values 'start' and 'end' to text-align property
http://bugs.webkit.org/show_bug.cgi?id=12521

Attachment 12855: removed BOM and tabs from test case
http://bugs.webkit.org/attachment.cgi?id=12855&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The test contains a call to dumpAsText -- I don't understand why because I
don't see how a plain-text dump would demonstrate whether the bug is fixed or
not.

Further, the patch contains a render tree dump in the expected.txt, not plain
text. There's no pixel test result: expected.checksum or expected.png.

If this is a plain-text test, then it needs a plain-text result. If not, then
it should not have code saying dumpAsText and it needs a pixel result.



More information about the webkit-reviews mailing list