[webkit-reviews] review granted: [Bug 14134] REGRESSION (r25353): Whitespace nodes ignored between inline list items : [Attachment 18221] Ensure that whitespace-only text nodes get a renderer when they need one

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 31 17:16:16 PST 2007


Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 14134: REGRESSION (r25353): Whitespace nodes ignored between inline list
items
http://bugs.webkit.org/show_bug.cgi?id=14134

Attachment 18221: Ensure that whitespace-only text nodes get a renderer when
they need one
http://bugs.webkit.org/attachment.cgi?id=18221&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 Node* next = nextSibling();
+	 while (next) {
+	     if (next->renderer())
+		 break;
+	     if (!next->attached())
+		 break;  // Assume this means none of the following siblings
are attached.
+	     if (next->isTextNode())
+		 next->createRendererIfNeeded();
+	     next = next->nextSibling();
+	 }

That should be a for loop.

r=me


More information about the webkit-reviews mailing list