[webkit-reviews] review granted: [Bug 16637] Acid3 expects ExeceptionCode constants to be defined on DOMException objects : [Attachment 18219] An exceptional patch (HAR HAR HAR)

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 16637: Acid3 expects ExeceptionCode constants to be defined on DOMException
objects
http://bugs.webkit.org/show_bug.cgi?id=16637

Attachment 18219: An exceptional patch (HAR HAR HAR)
http://bugs.webkit.org/attachment.cgi?id=18219&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 // FIXME: this is copied from ExceptionCode.h, it needs to be kept in
sync.

And both need to be kept in sync with the standard! Why can't DOMCoreException
use the values from ExceptionCode.h -- it includes that file, so it should be
able to. Can we change things later so these are defined only in the .idl file?


What about non-core errors?

Can we make sure the name "DOMCoreException" doesn't show through in
JavaScript?

+shouldBeEqualToString("e.constructor.toString()", "[object
DOMCoreExceptionConstructor]");

That should be "[object DOMExceptionConstructor]" -- we don't want to expose
the naming conflict issues in WebKit to the web content.

r=me