[webkit-reviews] review requested: [Bug 16654] [GTK] Signal "navigation-requested" does not react correctly on return TRUE from callbacks : [Attachment 18193] WebKitNavigationResponse accumulator.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 30 09:29:24 PST 2007


Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 16654: [GTK] Signal "navigation-requested" does not react correctly on
return TRUE from callbacks
http://bugs.webkit.org/show_bug.cgi?id=16654

Attachment 18193: WebKitNavigationResponse accumulator.
http://bugs.webkit.org/attachment.cgi?id=18193&action=edit

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
	* WebView/webkitwebview.cpp: use our own accumulator for signals
	returning WebKitNavigationResponse. The emission will be stopped
	when any callback returns anything but
	WEBKIT_NAVIGATION_RESPONSE_ACCEPT.
---
 WebKit/gtk/ChangeLog		      |   13 +++++++++++++
 WebKit/gtk/WebView/webkitwebview.cpp |   20 +++++++++++++++++++-
 2 files changed, 32 insertions(+), 1 deletions(-)


More information about the webkit-reviews mailing list